netdev - Re: [PATCH] allow ip_tables.h to be used from userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061205104622.7b86182e@freekitty>
Date:	Tue, 5 Dec 2006 10:46:22 -0800
From:	Stephen Hemminger <shemminger@...l.org>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netfilter-devel@...ts.netfilter.org, netdev@...r.kernel.org
Subject: Re: [PATCH] allow ip_tables.h to be used from userspace

On Tue, 05 Dec 2006 19:38:21 +0100
Patrick McHardy <kaber@...sh.net> wrote:

> Stephen Hemminger wrote:
> > The xtables version of ip_tables.h was no longer usable (in sanitized form)
> > by iproute2 and other applications because sparse annotations had crept
> > in.
> > 
> > @@ -194,7 +194,7 @@ struct ipt_replace
> >  	/* Number of counters (must be equal to current number of entries). */
> >  	unsigned int num_counters;
> >  	/* The old entries' counters. */
> > -	struct xt_counters __user *counters;
> > +	struct xt_counters *counters;
> 
> # Eliminate the contents of (and inclusions of) compiler.h
> 
> 
> HDRSED  := sed  -e "s/ inline / __inline__ /g" \
>                 -e "s/[[:space:]]__user[[:space:]]\+/ /g" \
>                 -e "s/(__user[[:space:]]\+/ (/g" \
> 
> I think this regex should be fixed instead to get rid of it
> while sanitizing (Makefile.headersinst).
> 

But ip_tables.h should still put include of compiler.h inside #ifdef __KERNEL__

-- 
Stephen Hemminger <shemminger@...l.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html