netdev - Re: [PATCH 1/5] ipw2100: Make ipw2100 depends on known working platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061205103607.GB10312@infradead.org>
Date:	Tue, 5 Dec 2006 10:36:07 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Zhu Yi <yi.zhu@...el.com>
Cc:	netdev@...r.kernel.org, "John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH 1/5] ipw2100: Make ipw2100 depends on known working platforms

On Tue, Dec 05, 2006 at 02:40:52PM +0800, Zhu Yi wrote:
> 
> [ Resubmit, if you still don't like it, I'll drop. ]
> 
> ipw2100 driver doesn't support big endian by now.
> 
> Signed-off-by: Karol Lewandowski <kl@...mine.eu.org>
> Signed-off-by: Zhu Yi <yi.zhu@...el.com>
> 
> ---
> 
>  drivers/net/wireless/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> d664c6332284edba4278a1f3b18b453ef4d39faf
> diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
> index aefa4cb..c2495c5 100644
> --- a/drivers/net/wireless/Kconfig
> +++ b/drivers/net/wireless/Kconfig
> @@ -146,7 +146,7 @@ comment "Wireless 802.11b ISA/PCI cards 
>  
>  config IPW2100
>  	tristate "Intel PRO/Wireless 2100 Network Connection"
> -	depends on NET_RADIO && PCI
> +	depends on NET_RADIO && PCI && (X86 || X86_64 || IA64 || BROKEN)

Once again, there's a lot more little endian than just you employers
hardware.  And once again the right thing for a maintained driver is
to fix the endianess bugs.  We should probably just mark it broken for
every platform given that intel doesn't care (And neither cares about
offers to fix endianess bugs if they send hardware..)

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html