netdev - Re: [PATCH] softmac: Fixed handling of deassociation from AP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200612061852.04216.mb@bu3sch.de>
Date:	Wed, 6 Dec 2006 18:52:03 +0100
From:	Michael Buesch <mb@...sch.de>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	kune@...ne-taler.de, netdev@...r.kernel.org,
	Bcm43xx-dev@...ts.berlios.de, Stefano Brivio <st3@...eup.net>,
	John Linville <linville@...driver.com>
Subject: Re: [PATCH] softmac: Fixed handling of deassociation from AP

On Wednesday 06 December 2006 15:45, Larry Finger wrote:
> From:  Ulrich Kunitz <kune@...ne-taler.de>
>  
> A deauthentication from the AP doesn't start a reassociation by
> SoftMAC. To fix this mac->associnfo.associating must be set and the
> ieee80211softmac_assoc_work function must be scheduled.
> 
> Signed-off-by: Ulrich Kunitz <kune@...ne-taler.de>
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
> 
>  net/ieee80211/softmac/ieee80211softmac_assoc.c |   14 ++++++++++++--
>  net/ieee80211/softmac/ieee80211softmac_auth.c  |    2 ++
>  net/ieee80211/softmac/ieee80211softmac_priv.h  |    2 ++
>  3 files changed, 16 insertions(+), 2 deletions(-)
> 
> Index: wireless-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
> ===================================================================
> --- wireless-2.6.orig/net/ieee80211/softmac/ieee80211softmac_assoc.c
> +++ wireless-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
> @@ -427,6 +427,17 @@ ieee80211softmac_handle_assoc_response(s
>  	return 0;
>  }
>  
> +void
> +ieee80211softmac_try_reassoc(struct ieee80211softmac_device *mac)
> +{
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&mac->lock, flags);
> +	mac->associnfo.associating = 1;
> +	schedule_work(&mac->associnfo.work);
> +	spin_unlock_irqrestore(&mac->lock, flags);
> +}

All data in mac->associnfo is protected by mac->associnfo->mutex
and _not_ mac->lock.

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html