netdev - Re: [PATCH 4/7] chelsio: use netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061205163921.61ea21e6@dxpl.pdx.osdl.net>
Date:	Tue, 5 Dec 2006 16:39:21 -0800
From:	Stephen Hemminger <shemminger@...l.org>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH 4/7] chelsio: use netdev_priv

On Wed, 6 Dec 2006 01:16:52 +0100
Francois Romieu <romieu@...zoreil.com> wrote:

> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> ---
>  drivers/net/chelsio/cxgb2.c |   60 +++++++++++++++++++++---------------------
>  drivers/net/chelsio/sge.c   |    4 +-
>  2 files changed, 32 insertions(+), 32 deletions(-)
> 
> diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c
> index cb639d4..15be058 100644
> --- a/drivers/net/chelsio/cxgb2.c
> +++ b/drivers/net/chelsio/cxgb2.c
> @@ -120,7 +120,7 @@ static const char pci_speed[][4] = {
>   */
>  static void t1_set_rxmode(struct net_device *dev)
>  {
> -	struct adapter *adapter = dev->priv;
> +	struct adapter *adapter = netdev_priv(dev);
>  	struct cmac *mac = adapter->port[dev->if_port].mac;
>  	struct t1_rx_mode rm;
> 

NAK for this driver. dev->priv points to a different location for each port on
dual port board.  To use netdev_priv() requires more serious surgery..


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html