netdev - RE: drivers/net/chelsio/my3126.c: inconsequent NULL checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8A71B368A89016469F72CD08050AD334E7216B@maui.asicdesigners.com>
Date:	Thu, 7 Dec 2006 07:56:43 -0800
From:	"Felix Marti" <felix@...lsio.com>
To:	<netdev@...r.kernel.org>, <jesper.juhl@...il.com>, <bunk@...sta.de>
Subject: RE: drivers/net/chelsio/my3126.c: inconsequent NULL checking


> Jesper Juhl <jesper.juhl@...il.com> wrote:
> On 07/12/06, Adrian Bunk <bunk@...sta.de> wrote:
> > The Coverity checker spotted the following inconsequent NULL
checking
> > introduced by commit f1d3d38af75789f1b82969b83b69cab540609789:
> >
> > <--  snip  -->
> >
> > ...
> > static struct cphy *my3126_phy_create(adapter_t *adapter,
> >                         int phy_addr, struct mdio_ops *mdio_ops)
> > {
> >         struct cphy *cphy = kzalloc(sizeof (*cphy), GFP_KERNEL);
> >
> >         if (cphy)
> >                 cphy_init(cphy, adapter, phy_addr, &my3126_ops,
mdio_ops);
> >
> >         INIT_WORK(&cphy->phy_update, my3216_poll, cphy);
> >         cphy->bmsr = 0;
> >
> >         return (cphy);
> > }
> > ...
> >
> > <--  snip  -->
> >
> > It doesn't make sense to first check whether "cphy" is NULL and
> > dereference it unconditionally later.
> >
> 
> How about simply changing
>          if (cphy)
>                  cphy_init(cphy, adapter, phy_addr, &my3126_ops,
mdio_ops);
> into
>          if (!cphy)
>                  return NULL;
> 
> callers need to be able to handle that ofcourse, but I haven't checked
that
> yet.

[Felix Marti] Yes, returning NULL on allocation failure is the way to
go. The caller does handle it.

> 
> --
> Jesper Juhl <jesper.juhl@...il.com>
> Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please      http://www.expita.com/nomime.html
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html