netdev - Re: Please make CONFIG_CFG80211 harder to enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165756653.3131.1.camel@johannes.berg>
Date:	Sun, 10 Dec 2006 14:17:33 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Pavel Roskin <proski@....org>
Cc:	Paul Collins <paul@...ny.ondioline.org>,
	"John W. Linville" <linville@...driver.com>, netdev@...r.kernel.org
Subject: Re: Please make CONFIG_CFG80211 harder to enable

On Sun, 2006-12-10 at 03:12 -0500, Pavel Roskin wrote:

> Sorry, it looks like the evil setting is actually CONFIG_CFG80211_WEXT_COMPAT.
> I should have checked it better.  Please look for the code around the
> cfg80211_wext_ioctl call in dev_ioctl(), net/core/dev.c.
> 
> The logic now is to try the compatibility code first.  I think it's wrong, at
> least for now.  I think the compatibility code should only be invoked if the
> native WE support failed for the request.  Or maybe if the cfg80211 support is
> present for the driver.

No, it's correct. Re-read the code.

> Yes.  And I could trace "iwgetid -m ath0" to cfg80211_wx_get_mode() in
> net/wireless/wext-compat.c, which returns -ENOSYS unconditionally.  ath0 is
> from current MadWifi.

Now trace it further and notice that on -ENOSYS the original WE is
invoked.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)