netdev - Re: [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165772658.3131.34.camel@johannes.berg>
Date:	Sun, 10 Dec 2006 18:44:18 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Ulrich Kunitz <kune@...ne-taler.de>
Cc:	netdev@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	Andrew Morton <akpm@...l.org>, dsd@...too.org
Subject: Re: [PATCH] ieee80211softmac: Fix mutex_lock at exit of
	ieee80211_softmac_get_genie

On Sun, 2006-12-10 at 18:27 +0100, Ulrich Kunitz wrote:
> ieee80211softmac_wx_get_genie locks the associnfo mutex at
> function exit. This patch fixes it. The patch is against Linus'
> tree (commit af1713e0).

Looks good, I wonder how this slipped in.

Acked-by: Johannes Berg <johannes@...solutions.net>

> Signed-off-by: Ulrich Kunitz <kune@...ne-taler.de>
> ---
>  net/ieee80211/softmac/ieee80211softmac_wx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
> index 480d72c..fa2f7da 100644
> --- a/net/ieee80211/softmac/ieee80211softmac_wx.c
> +++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
> @@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net
>  			err = -E2BIG;
>  	}
>  	spin_unlock_irqrestore(&mac->lock, flags);
> -	mutex_lock(&mac->associnfo.mutex);
> +	mutex_unlock(&mac->associnfo.mutex);
>  
>  	return err;
>  }

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)