netdev - Re: [PATCH 01/22] e1000: Fix early TSO completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <457D6CDE.8070400@pobox.com>
Date:	Mon, 11 Dec 2006 09:36:14 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	"Kok, Auke" <auke-jan.h.kok@...el.com>
CC:	netdev@...r.kernel.org,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Kok, Auke" <auke@...-projects.org>,
	"Ronciak, John" <john.ronciak@...el.com>
Subject: Re: [PATCH 01/22] e1000: Fix early TSO completion

Kok, Auke wrote:
> This fix was already merged in commit 96f9c2e277768099479fbed7c3b69c294b1fadef
> but reverted in commit 989316ddfeafd0e8fb51a4d811383769ad62637a. After
> stresstesting we found that the fix does not add new regressions and
> works around a TX hang spotted by several users.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>

ACK content except for one detail:  don't add new NETIF_F_TSO ifdefs. 
Modern 2.6 kernel code should simply assume that TSO is present.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html