lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <457EF632.4060106@intel.com> Date: Tue, 12 Dec 2006 10:34:26 -0800 From: Auke Kok <auke-jan.h.kok@...el.com> To: Yan Burman <burman.yan@...il.com> CC: linux-kernel@...r.kernel.org, trivial@...nel.org, john.ronciak@...el.com, NetDev <netdev@...r.kernel.org>, Jeff Garzik <jgarzik@...ox.com> Subject: Re: [PATCH 2.6.19] e100: replace kmalloc with kcalloc Yan Burman wrote: > Replace kmalloc+memset with kcalloc ACK, fine with me. > Signed-off-by: Yan Burman <burman.yan@...il.com> > > diff -rubp linux-2.6.19-rc5_orig/drivers/net/e100.c linux-2.6.19-rc5_kzalloc/drivers/net/e100.c > --- linux-2.6.19-rc5_orig/drivers/net/e100.c 2006-11-09 12:16:21.000000000 +0200 > +++ linux-2.6.19-rc5_kzalloc/drivers/net/e100.c 2006-11-11 22:44:04.000000000 +0200 > @@ -1930,9 +1930,8 @@ static int e100_rx_alloc_list(struct nic > nic->rx_to_use = nic->rx_to_clean = NULL; > nic->ru_running = RU_UNINITIALIZED; > > - if(!(nic->rxs = kmalloc(sizeof(struct rx) * count, GFP_ATOMIC))) > + if(!(nic->rxs = kcalloc(count, sizeof(struct rx), GFP_ATOMIC))) > return -ENOMEM; > - memset(nic->rxs, 0, sizeof(struct rx) * count); > > for(rx = nic->rxs, i = 0; i < count; rx++, i++) { > rx->next = (i + 1 < count) ? rx + 1 : nic->rxs; > > > > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists