netdev - Re: kernel panic with the newly merged md5 signature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Dec 2006 14:25:23 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	leigh@...inno.co.uk
Cc:	netdev@...r.kernel.org
Subject: Re: kernel panic with the newly merged md5 signature support

From: "Leigh Brown" <leigh@...inno.co.uk>
Date: Tue, 12 Dec 2006 22:22:13 -0000 (GMT)

> I'm not sure what the correct way forward is.  Could these functions
> not be just:
> 
> struct tcp_md5sig_pool *__tcp_get_md5sig_pool(int cpu)
> {
>         struct tcp_md5sig_pool **p = tcp_md5_sig_pool;
> 	BUG_ON(!p);
> 	return *per_cpu_ptr(p, cpu);
> }
> 
> void __tcp_put_md5sig_pool(void) {
>         /* nuffin */
> }
> 
> In other words, can we assume that the pool is allocated when we call
> tcp_get_md5sig_pool?

I think the issue is that we need to get a balanced get_cpu()/put_cpu()
in there somehow.

I'll take a look at this later today, thanks for pointing it out.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html