netdev - Re: kernel panic with the newly merged md5 signature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061212.172935.106265967.davem@davemloft.net>
Date:	Tue, 12 Dec 2006 17:29:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	leigh@...inno.co.uk
Cc:	netdev@...r.kernel.org
Subject: Re: kernel panic with the newly merged md5 signature support

From: "Leigh Brown" <leigh@...inno.co.uk>
Date: Tue, 12 Dec 2006 23:03:34 -0000 (GMT)

> Well, the inline functions seem okay in that regard, but I'll bow to
> your superior judgement.

I think we're still not onto the right fix.

I took a look, and the issue seems to simply be that the
__tcp_put_md5sig_pool() is not doing the reference count
thing that __tcp_get_md5sig_pool() does (via tcp_md5sig_users).

The direct call to __tcp_free_md5sig_pool() seems to be
what causes this problem, we should be invoking
tcp_free_md5sig_pool() instead.

Can you give this patch a try?  Thanks.

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 090c690..4c57019 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2364,8 +2364,9 @@ struct tcp_md5sig_pool *__tcp_get_md5sig
 
 EXPORT_SYMBOL(__tcp_get_md5sig_pool);
 
-void __tcp_put_md5sig_pool(void) {
-	__tcp_free_md5sig_pool(tcp_md5sig_pool);
+void __tcp_put_md5sig_pool(void)
+{
+	tcp_free_md5sig_pool(tcp_md5sig_pool);
 }
 
 EXPORT_SYMBOL(__tcp_put_md5sig_pool);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html