netdev - Re: [PATCH 3/6] d80211: fix classify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061214121358.6bd586b0@griffin.suse.cz>
Date:	Thu, 14 Dec 2006 12:13:58 +0100
From:	Jiri Benc <jbenc@...e.cz>
To:	yi.zhu@...el.com
Cc:	netdev@...r.kernel.org, Jouni Malinen <jkm@...icescape.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH 3/6] d80211: fix classify_1d() priority selection

On Thu, 14 Dec 2006 12:02:27 +0800, Zhu Yi wrote:
> I don't see any reason why packets with DSCP=0x40 should have lower IEEE
> 802.1D priority than packets with DSCP=0x20. Spare > Background. No?

Hm, seems so. Jouni, is there any reason for this?

> 
> Signed-off-by: Zhu Yi <yi.zhu@...el.com>
> 
> ---
> 
>  net/d80211/wme.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> e1765ea0d80ad86619300d3253e801883fd745a5
> diff --git a/net/d80211/wme.c b/net/d80211/wme.c
> index b9505dc..f26fe6c 100644
> --- a/net/d80211/wme.c
> +++ b/net/d80211/wme.c
> @@ -131,9 +131,9 @@ static inline unsigned classify_1d(struc
>  	dscp = ip->tos & 0xfc;
>  	switch (dscp) {
>  	case 0x20:
> -		return 2;
> -	case 0x40:
>  		return 1;
> +	case 0x40:
> +		return 2;
>  	case 0x60:
>  		return 3;
>  	case 0x80:

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html