netdev - Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1166055763.6838.5.camel@concordia.ozlabs.ibm.com>
Date:	Thu, 14 Dec 2006 11:22:43 +1100
From:	Michael Ellerman <michael@...erman.id.au>
To:	Linas Vepstas <linas@...tin.ibm.com>
Cc:	Andrew Morton <akpm@...l.org>, Arnd Bergmann <arnd@...db.de>,
	netdev@...r.kernel.org, Christoph Hellwig <hch@...radead.org>,
	linuxppc-dev@...abs.org, Jens Osterkamp <Jens.Osterkamp@....de>,
	jgarzik@...ox.com, James K Lewis <jim@...ewis.com>
Subject: Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

On Wed, 2006-12-13 at 15:23 -0600, Linas Vepstas wrote:
> Delete possible source of chain corruption; the hardware
> already knows the location of the tail, and writing it
> again is likely to mess it up.
> 
> Signed-off-by: Linas Vepstas <linas@...tin.ibm.com>
> Cc: James K Lewis <jklewis@...ibm.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> 
> ----
> 
>  drivers/net/spider_net.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-2.6.19-git7/drivers/net/spider_net.c
> ===================================================================
> --- linux-2.6.19-git7.orig/drivers/net/spider_net.c	2006-12-13 14:28:23.000000000 -0600
> +++ linux-2.6.19-git7/drivers/net/spider_net.c	2006-12-13 14:28:25.000000000 -0600
> @@ -513,7 +513,6 @@ spider_net_alloc_rx_skbs(struct spider_n
>  	/* This will allocate the rest of the rx buffers;
>  	 * if not, it's business as usual later on. */
>  	spider_net_refill_rx_chain(card);
> -	spider_net_enable_rxchtails(card);
>  	spider_net_enable_rxdmac(card);
>  	return 0;

Didn't you just add that line?

From "[PATCH 10/14] Spidernet RX Chain tail":

> @@ -501,17 +501,18 @@ spider_net_alloc_rx_skbs(struct spider_n
> 
> <snip comment change>
>  
> -       /* this will allocate the rest of the rx buffers; if not, it's
> -        * business as usual later on */
> +       /* This will allocate the rest of the rx buffers;
> +        * if not, it's business as usual later on. */
>         spider_net_refill_rx_chain(card);
> +       spider_net_enable_rxchtails(card);
>         spider_net_enable_rxdmac(card);
>         return 0;

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)