netdev - Re: [patch 03/14] e1000: omit stats for broken counter in 82543

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4582B21F.8090907@linux.intel.com>
Date:	Fri, 15 Dec 2006 15:33:03 +0100
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	netdev@...r.kernel.org
Subject: Re: [patch 03/14] e1000: omit stats for broken counter in 82543

Jeff Garzik wrote:
> Needs to use an "i have broken stats" feature flag, rather than adding 
> yet another mac_type test into the code.  This testing of MAC type 
> rather than feature flags is a major e1000 problem, and it bloats the 
> driver quite a bit.  Intel has been told for /months/ this is a problem, 
> yet I still see patches like this.
> 
it is "nice" that you say this, and Intel is working on a "flags" 
based driver. However that is, as you state yourself here, a major 
invasive change, and thus not suitable for 2.6.20 inclusion. Yet these 
fixes are important bugfixes; I don't think it's fair to hold these 
hostage..

Greetings,
   Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html