netdev - [patch] scrub non-__GLIBC__ checks in linux/socket.h and linux/stat.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Dec 2006 13:42:11 -0500
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	viro@...iv.linux.org.uk
Cc:	"Alexey Dobriyan" <adobriyan@...il.com>,
	"Robert P. J. Day" <rpjday@...dspring.com>
Subject: [patch] scrub non-__GLIBC__ checks in linux/socket.h and linux/stat.h

On 11/30/06, Robert P. J. Day <rpjday@...dspring.com> wrote:
> but there are a few other
> cases which still contain compound preprocessor directives such as:
>
>   #if defined(__KERNEL__) || !defined(__GLIBC__) || (__GLIBC__ < 2)
>
> having never worked with unifdef before, i guess i was being overly
> optimistic in thinking that it, if i "unifdef"ed __KERNEL__, it might
> at least simplify the expression.  oh, well ... live and learn.

userspace should be worrying about userspace, so having the socket.h
and stat.h pollute the namespace in the non-glibc case is wrong and
pretty much prevents any other libc from utilizing these headers
sanely unless they set up the __GLIBC__ define themselves (which
sucks)
-mike

Download attachment "linux-scrub-GLIBC-ifdefs.patch" of type "application/octet-stream" (729 bytes)