netdev - Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200612152152.25419.flamingice@sourmilk.net>
Date:	Fri, 15 Dec 2006 21:52:20 -0500
From:	Michael Wu <flamingice@...rmilk.net>
To:	Marcelo Tosatti <marcelo@...ck.org>
Cc:	netdev <netdev@...r.kernel.org>, Jeff Garzik <jgarzik@...ox.com>,
	Dan Williams <dcbw@...hat.com>,
	"Luis R. Rodriguez" <mcgrof@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	"John W. Linville" <linville@...hat.com>, dyoung@...ox.com
Subject: Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver

On Friday 15 December 2006 17:51, Marcelo Tosatti wrote:
>--- a/include/net/ieee80211_radiotap.h
>+++ b/include/net/ieee80211_radiotap.h
>@@ -168,6 +168,23 @@ struct ieee80211_radiotap_header {
>  *      Unitless indication of the Rx/Tx antenna for this packet.
>  *      The first antenna is antenna 0.
>  *
>+ * IEEE80211_RADIOTAP_RX_FLAGS          u_int16_t       bitmap
>+ *
>+ *     Properties of received frames. See flags defined below.
>+ *
>+ * IEEE80211_RADIOTAP_TX_FLAGS          u_int16_t       bitmap
>+ *
>+ *     Properties of transmitted frames. See flags defined below.
>+ *
>+ * IEEE80211_RADIOTAP_RTS_RETRIES       u_int8_t        data
>+ *
>+ *     Number of rts retries a transmitted frame used.
>+ *
>+ * IEEE80211_RADIOTAP_DATA_RETRIES      u_int8_t        data
>+ *
>+ *     Number of unicast retries a transmitted frame used.
>+ *
>+ *
>  * IEEE80211_RADIOTAP_FCS              u32       data
>  *
>  *     FCS from frame in network byte order.
>@@ -187,7 +204,11 @@ enum ieee80211_radiotap_type {
>        IEEE80211_RADIOTAP_ANTENNA = 11,
>        IEEE80211_RADIOTAP_DB_ANTSIGNAL = 12,
>        IEEE80211_RADIOTAP_DB_ANTNOISE = 13,
>-       IEEE80211_RADIOTAP_EXT = 31,
>+       IEEE80211_RADIOTAP_RX_FLAGS = 14,
>+       IEEE80211_RADIOTAP_TX_FLAGS = 15,
>+       IEEE80211_RADIOTAP_RTS_RETRIES = 16,
>+       IEEE80211_RADIOTAP_DATA_RETRIES = 17,
>+       IEEE80211_RADIOTAP_EXT = 31
> };
>
> /* Channel flags. */
Did you send this part to netbsd also? We really don't want to fork 
radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's 
all rolled together for convenience.

-Michael Wu

Content of type "application/pgp-signature" skipped