netdev - Re: [KJ] [PATCH] he: tiny space savings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061217200625.GE10316@stusta.de>
Date:	Sun, 17 Dec 2006 21:06:25 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	netdev@...r.kernel.org,
	Andi Drebes <webmaster@...grammierforen.de>,
	kernel-janitors@...ts.osdl.org
Subject: Re: [KJ] [PATCH] he: tiny space savings

On Sun, Dec 17, 2006 at 11:02:55PM +0300, Alexey Dobriyan wrote:
> On Sun, Dec 17, 2006 at 07:28:06PM +0100, Adrian Bunk wrote:
> > On Sun, Dec 17, 2006 at 03:56:22PM +0300, Alexey Dobriyan wrote:
> > > From: Andi Drebes <webmaster@...grammierforen.de>
> > >    text    data     bss     dec     hex filename
> > >   20015     480      28   20523    502b drivers/atm/he.o
> > >   19997     480      28   20505    5019 drivers/atm/he.o
> > >
> > > Signed-off-by: Andi Drebes <webmaster@...grammierforen.de>
> > > Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> > > ---
> > >
> > >  drivers/atm/he.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- a/drivers/atm/he.c
> > > +++ b/drivers/atm/he.c
> > > @@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
> > >
> > >  /* version definition */
> > >
> > > -static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> > > +static const char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> > >...
> >
> > Can't we kill this ancient and outdated version string instead?
> 
> "version" is involved in he_proc_read(). I think, no.

You don;t have to omit this line, but printing a more than 3 years old 
CVS tag is silly (I can't believe anyone is parsing the CVS version).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html