lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061218000807.GM23747@xi.wantstofly.org>
Date:	Mon, 18 Dec 2006 01:08:07 +0100
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: use the broken_parity_status field in pci_dev

On Mon, Dec 18, 2006 at 12:04:19AM +0100, Francois Romieu wrote:

> The former option is removed and platform code can now specify the
> expected behavior.

Thanks a lot.

FYI, I submitted this patch for the n2100 side:


Index: linux-2.6.19/arch/arm/mach-iop32x/n2100.c
===================================================================
--- linux-2.6.19.orig/arch/arm/mach-iop32x/n2100.c
+++ linux-2.6.19/arch/arm/mach-iop32x/n2100.c
@@ -123,9 +123,26 @@ static struct hw_pci n2100_pci __initdat
 
 static int __init n2100_pci_init(void)
 {
-	if (machine_is_n2100())
+	if (machine_is_n2100()) {
+		int i;
+
 		pci_common_init(&n2100_pci);
 
+		/*
+		 * Both r8169 chips on the n2100 exhibit PCI parity
+		 * problems.  Set the ->broken_parity_status flag for
+		 * both ports so that the r8169 driver knows it should
+		 * ignore error interrupts.
+		 */
+		for (i = 1; i <= 2; i++) {
+			struct pci_dev *dev;
+
+			dev = pci_get_bus_and_slot(0, PCI_DEVFN(i, 0));
+			if (dev != NULL)
+				dev->broken_parity_status = 1;
+		}
+	}
+
 	return 0;
 }
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ