netdev - Re: [PATCH]Fix BUG of ip_rt_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061218055618.GA9386@gondor.apana.org.au>
Date:	Mon, 18 Dec 2006 16:56:18 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Li Yewang <lyw@...jing-fnst.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH]Fix BUG of ip_rt_send_redirect()

On Wed, Nov 29, 2006 at 04:51:31PM +0800, Li Yewang wrote:
> 
> I have also checked other spots where rate_last/rate_tokens is used.
> Those places need not be fixed.

Thanks.

> Following is my patch:
> 
> signed-off-by: Li Yewang<lyw@...jing-fnst.com>

Looks good to me.  You should cc David Miller <davem@...emloft.net>
for patch submissions.  Please also include a full description each
time you submit the patch.

> --- linux-2.6.19.1/net/ipv4/route.c     2006-12-12 03:32:54.000000000
> +0800
> +++ linux-2.6.19.1/net/ipv4/route.org.c 2006-11-29 16:14:34.592058480
> +0800
> @@ -1327,7 +1327,8 @@ void ip_rt_send_redirect(struct sk_buff
>         /* Check for load limit; set rate_last to the latest sent
>          * redirect.
>          */
> -       if (time_after(jiffies,
> +       if (rt->u.dst.rate_tokens == 0 ||
> +            time_after(jiffies,
>                        (rt->u.dst.rate_last +
>                         (ip_rt_redirect_load << rt-
> >u.dst.rate_tokens)))) {
>                 icmp_send(skb, ICMP_REDIRECT, ICMP_REDIR_HOST, rt-
> >rt_gateway);

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html