netdev - Re: [PATCH] ieee80211: WLAN_GET_SEQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4586C6D1.5060607@lwfinger.net>
Date:	Mon, 18 Dec 2006 10:50:25 -0600
From:	Larry Finger <larry.finger@...inger.net>
To:	yi.zhu@...el.com
CC:	netdev@...r.kernel.org, "John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH] ieee80211: WLAN_GET_SEQ_SEQ fix

Zhu Yi wrote:
> Signed-off-by: Zhu Yi <yi.zhu@...el.com>
> 
> diff --git a/include/net/ieee80211.h b/include/net/ieee80211.h
> index e6af381..e02d85f 100644
> --- a/include/net/ieee80211.h
> +++ b/include/net/ieee80211.h
> @@ -218,7 +218,7 @@ struct ieee80211_snap_hdr {
>  #define WLAN_FC_GET_STYPE(fc) ((fc) & IEEE80211_FCTL_STYPE)
>  
>  #define WLAN_GET_SEQ_FRAG(seq) ((seq) & IEEE80211_SCTL_FRAG)
> -#define WLAN_GET_SEQ_SEQ(seq)  ((seq) & IEEE80211_SCTL_SEQ)
> +#define WLAN_GET_SEQ_SEQ(seq)  (((seq) & IEEE80211_SCTL_SEQ) >> 4)
>  
>  /* Authentication algorithms */
>  #define WLAN_AUTH_OPEN 0
> -

Shouldn't this fix have some commit message like "The WLAN_GET_SEQ_SEQ(seq) macro in ieee80211 is 
selecting the wrong region."? That said, the fix conforms with the IEEE802.11 specs.

Signed-off-by: Larry Finger <Larry.Finger@...inger.net>

Larry
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html