netdev - Re: [PATCH] d80211: add radiotap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061218172044.GC31832@devicescape.com>
Date:	Mon, 18 Dec 2006 09:20:44 -0800
From:	David Kimdon <david.kimdon@...icescape.com>
To:	Michael Wu <flamingice@...rmilk.net>
Cc:	Jiri Benc <jbenc@...e.cz>, netdev@...r.kernel.org,
	John Linville <linville@...driver.com>
Subject: Re: [PATCH] d80211: add radiotap support

On Sat, Dec 16, 2006 at 06:01:03PM -0500, Michael Wu wrote:
>  	skb->mac.raw = skb->data;
>  	skb->ip_summed = CHECKSUM_UNNECESSARY;
>  	skb->pkt_type = PACKET_OTHERHOST;
> -	skb->protocol = htons(ETH_P_802_2);
> +	skb->protocol = __constant_htons(ETH_P_802_2);
>  	memset(skb->cb, 0, sizeof(skb->cb));
>  	netif_rx(skb);

htons and friends can handle determining the argument is a constant on
their own, so this change should be dropped.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html