netdev - Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061222125327.GA3138@ff.dom.local>
Date:	Fri, 22 Dec 2006 13:53:27 +0100
From:	Jarek Poplawski <jarkao2@...pl>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	greearb@...delatech.com, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

On Fri, Dec 22, 2006 at 10:16:30PM +1100, Herbert Xu wrote:
> Jarek Poplawski <jarkao2@...pl> wrote:
> >
> > [PATCH] igmp: spin_lock_bh in timer
> > 
> > igmp_timer_expire() uses spin_lock(&im->lock)
> > but this lock is also taken by other igmp timers,
> > so it should be changed to bh version.
> 
> When you're in a timer BH is already disabled.  So this patch
> is redundant.

Yes, I recognized this "after the damage was done".

Thanks and regards,

Jarek P.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html