netdev - Re: removing gotos considered harmful...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39e6f6c70612221311t277f28a2j6378bcef7ad4c374@mail.gmail.com>
Date:	Fri, 22 Dec 2006 19:11:48 -0200
From:	"Arnaldo Carvalho de Melo" <arnaldo.melo@...il.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, gerrit@....abdn.ac.uk
Subject: Re: removing gotos considered harmful...

On 12/22/06, David Miller <davem@...emloft.net> wrote:
>
> Because of massively painful regressions like the following,
> I absolutely refuse to apply "cleanup" patches to remove gotos
> for "clarity".  All such patches do is change the code and
> potentially add bugs, they don't help in any way at all.
>
> Gerrit, please be more careful next time, and resist the urge to "fix"
> stuff that isn't broken just to satisfy your own personal coding
> tastes during a conversion.  This is a locally exploitable hole,
> all someone has to do is open a few hundred UDP sockets to a
> particular destination port and then nobody, not even root, can
> so much as run ping successfully.
>
> Arnaldo, sorry I originally thought this bug was added by you, you're
> totally innocent this time :-)))

Was so fast I wasn't even able to plead "not guilty!" :-)

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html