netdev - Re: [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Dec 2006 13:53:49 +0900
From:	Keiichi KII <k-keiichi@...jp.nec.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	mpm@...enic.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs

Thank you for your replies and reviews.

I will follow your advices.

>>  static LIST_HEAD(target_list);
>>  
>>  static DEFINE_SPINLOCK(target_list_lock);
>>  
>> +static ssize_t show_local_ip(struct netconsole_target *nt, char *buf)
>> +{
>> +	return sprintf(buf, "%d.%d.%d.%d\n", HIPQUAD(nt->np.local_ip));
> 
> I don't understand the use of HIPQUAD() here instead of
> NIPQUAD().  Explain?
> 
> Also, NIPQUAD_FMT (in kernel.h) uses "%u.%u.%u.%u".
> This should probably be the same.
> Or just use:	NIPQUAD_FMT "\n"

IP address is stored in the form of host byte order in netpoll structure.
So, You can't use NIPQUAD to follow the current implementation of netpoll.

-- 
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: k-keiichi@...jp.nec.com


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html