netdev - Re: [PATCH 1/5] myri10ge: match number of save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Dec 2006 16:28:40 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Brice Goglin <brice@...i.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/5] myri10ge: match number of save_state and restore

Brice Goglin wrote:
> Since pci_save_state() pushes MSI and PCIe states on a kind of stack,
> myri10ge saving the state in advance for parity recovery will push the
> state again on the stack on suspend. This leads to some memory leak.
> We add a couple additional calls to save_state and restore_state so
> that we don't leak anymore.
> 
> For the future, we are thinking of a better way to recover from parity
> error without using pci_save_state().
> 
> Signed-off-by: Brice Goglin <brice@...i.com>

applied 1-5


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html