netdev - Re: [PATCH 7/8] NetXen: Fix for PPC machines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061227080633.GN17561@ftp.linux.org.uk>
Date:	Wed, 27 Dec 2006 08:06:33 +0000
From:	Al Viro <viro@....linux.org.uk>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	"Amit S. Kale" <amitkale@...xen.com>, netdev@...r.kernel.org,
	brazilnut@...ibm.com, jeff@...zik.org, netxenproj@...syssoft.com,
	rob@...xen.com, sanjeev@...xen.com, wendyx@...ibm.com
Subject: Re: [PATCH 7/8] NetXen: Fix for PPC machines.

On Wed, Dec 27, 2006 at 07:58:54AM +0000, Christoph Hellwig wrote:
> On Mon, Dec 18, 2006 at 05:53:59AM -0800, Amit S. Kale wrote:
> > Signed-off-by: Amit S. Kale <amitkale@...xen.com> 
> >  
> >  netxen_nic.h      |    2 +-
> >  netxen_nic_init.c |   12 ++++++------
> >  netxen_nic_main.c |    4 ++--
> >  3 files changed, 9 insertions(+), 9 deletions(-)
> 
> Please use __le* types for all hardware data structures and use sparse
> to verify all your endianess handling is correct.

I have preliminary endianness annotations for that puppy; FWIW, a part of
it consists of _removing_ __le.  Folks, readl() returns host-endian and
writel() takes host-endian as argument.  They do conversions themselves.
One needs fixed-endian types in data structures shared with device - i.e.
anything in ioremapped area or dma'd to/from device.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html