netdev - Re: d80211 constants inside d80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Dec 2006 14:12:15 -0500
From:	Michael Wu <flamingice@...rmilk.net>
To:	"Nick Kossifidis" <mickflemm@...il.com>
Cc:	netdev@...r.kernel.org,
	"David Kimdon" <david.kimdon@...icescape.com>,
	linville@...driver.com, jbenc@...e.cz
Subject: Re: d80211 constants inside d80211_common.h

On Wednesday 27 December 2006 12:26, Nick Kossifidis wrote:
> We need those definitions for setting up the rate tables in dadwifi,
> phytypes are needed inside drivers, take a look here ->
> http://madwifi.org/browser/branches/dadwifi-openhal/openhal/ar5xxx.h?rev=18
>67
>
MODE_IEEE80211A/B/G and IEEE80211_RATE_* not enough? The definitions in 
d80211_common.h are used for communications with userspace, not drivers. If 
you are using the ieee80211_phytype_* in things that are passed to d80211, it 
is wrong. If you are not, you can switch to MODE_IEEE80211A/B/G and 
IEEE80211_RATE_*, though I think MODE_IEEE80211A/B/G should be all you need.

> Even if it does get out, constants should be in capitals.
>
Sure. Submit a patch. :)

-Michael Wu

Content of type "application/pgp-signature" skipped