netdev - Re: [PATCH] d80211: Reinit keys on mode change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a32f33a40701020731j4943c268qf5371ee2243f4d27@mail.gmail.com>
Date:	Tue, 2 Jan 2007 16:31:22 +0100
From:	"Ivo Van Doorn" <ivdoorn@...il.com>
To:	"Jan Kiszka" <jan.kiszka@....de>
Cc:	"Jiri Benc" <jbenc@...e.cz>, netdev@...r.kernel.org,
	rt2400-devel@...ts.sourceforge.net
Subject: Re: [PATCH] d80211: Reinit keys on mode change

On 1/1/07, Jan Kiszka <jan.kiszka@....de> wrote:
> Switching the interface mode with some encryption keys set and then later
> touching any key, triggers an oops because ieee80211_if_reinit fails to
> NULL'ify the related pointers after free'ing the key on mode change. Long
> explanation, simple fix below.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@....de>
>
> [Sorry, yet another rt2x00 CVS patch...]

To make it easier for everybody, here is the same patch
only this time applied to the dscape git tree. ;)

Signed-off-by: Jan Kiszka <jan.kiszka@....de>
Signed-off-by: Ivo van Doorn <IvDoorn@...il.com>

---

diff --git a/net/d80211/ieee80211_iface.c b/net/d80211/ieee80211_iface.c
index 3e9d531..7d4ec56 100644
--- a/net/d80211/ieee80211_iface.c
+++ b/net/d80211/ieee80211_iface.c
@@ -229,6 +229,7 @@ void ieee80211_if_reinit(struct net_device *dev)
 					   local->keys[i], 0);
 #endif
 		ieee80211_key_free(sdata->keys[i]);
+		sdata->keys[i] = NULL;
 	}

 	/* Shouldn't be necessary but won't hurt */
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html