netdev - Re: [PATCH 2.6.19 1/2] X.25: Adds call forwarding to X.25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070104102702.30630a9d@localhost.localdomain>
Date:	Thu, 4 Jan 2007 10:27:02 +0000
From:	Alan <alan@...rguk.ukuu.org.uk>
To:	ahendry <ahendry@...c.com.au>
Cc:	linux-x25@...r.kernel.org, eis@...y.hanse.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.19 1/2] X.25: Adds call forwarding to X.25

> +	struct sk_buff *skbn;
> +	skbn = skb_clone(skb, GFP_ATOMIC);
> +

If this fails then you starting passing NULL around. I'm also a bit
confused as to where you free the copy in all the error cases ?

Is there any reason for creating skbn here rather than in
skb_forward_call ?

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html