lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Jan 2007 20:38:47 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Jarek Poplawski <jarkao2@...pl> Cc: David Miller <davem@...emloft.net>, dlstevens@...ibm.com, greearb@...delatech.com, netdev@...r.kernel.org Subject: Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks) On Fri, Jan 05, 2007 at 07:38:44AM +0100, Jarek Poplawski wrote: > > I'd only suggest to change "goto out;" to > "return NULL;" at the end of inetdev_init because > now RCU is engaged unnecessarily. I agree. The RCU assignment should come before the out label. Can you send a patch? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists