netdev - Re: [PATCH] devinet: inetdev_init out label moved after RCU assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Jan 2007 11:52:54 -0800
From:	David Stevens <dlstevens@...ibm.com>
To:	Jarek Poplawski <jarkao2@...pl>
Cc:	David Miller <davem@...emloft.net>, greearb@...delatech.com,
	Herbert Xu <herbert@...dor.apana.org.au>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] devinet: inetdev_init out label moved after RCU assignment

Yeah, sure.

                +-DLS

Acked-by: David L Stevens <dlstevens@...ibm.com>

> Signed-off-by: Jarek Poplawski <jarkao2@...pl>
> 
> ---
> 
> diff -Nurp linux-2.6.20-rc3-/net/ipv4/devinet.c 
linux-2.6.20-rc3/net/ipv4/devinet.c
> --- linux-2.6.20-rc3-/net/ipv4/devinet.c   2007-01-05 11:53:16.000000000 
+0100
> +++ linux-2.6.20-rc3/net/ipv4/devinet.c   2007-01-05 11:55:32.000000000 
+0100
> @@ -174,9 +174,10 @@ struct in_device *inetdev_init(struct ne
>     ip_mc_init_dev(in_dev);
>     if (dev->flags & IFF_UP)
>        ip_mc_up(in_dev);
> -out:
> +
>     /* we can receive as soon as ip_ptr is set -- do this last */
>     rcu_assign_pointer(dev->ip_ptr, in_dev);
> +out:
>     return in_dev;
>  out_kfree:
>     kfree(in_dev);
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html