netdev - Re: [PATCH][RFC] tcp: fix ambiguity in the `before' relation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070105203443.GA25173@gondor.apana.org.au>
Date:	Sat, 6 Jan 2007 07:34:43 +1100
From:	Herbert Xu <herbert.xu@...hat.com>
To:	Gerrit Renker <gerrit@....abdn.ac.uk>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH][RFC] tcp: fix ambiguity in the `before' relation

On Fri, Jan 05, 2007 at 12:49:13PM +0000, Gerrit Renker wrote:
> 
> Since the old definition is not used in the way "before(x, y) && !before(y, x)", but rather in the
> fashion "before(x, y)" or "after(y, x)", the main advantage of the new definition is that it makes
> this type of use a safe case. 

This is not true because

	if (before(x, y))
		goto drop;

means that you're effectively using it as !before(x, y).  In other words,
the change is good if our code read

	if (before(x, y))
		process_packet();

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html