netdev - Re: [PATCH] d80211: Fix inconsistent sta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <459FCF58.1060206@web.de>
Date:	Sat, 06 Jan 2007 17:33:28 +0100
From:	Jan Kiszka <jan.kiszka@....de>
To:	Ivo van Doorn <ivdoorn@...il.com>
CC:	Jiri Benc <jbenc@...e.cz>, Christoph Hellwig <hch@...radead.org>,
	netdev@...r.kernel.org, rt2400-devel@...ts.sourceforge.net
Subject: Re: [PATCH] d80211: Fix inconsistent sta_lock usage

Ivo van Doorn wrote:
> +#define __bss_tim_set(__bss, __aid)	__set_bit((__aid), &(__bss)->tim)
> +

__set/clear_bit demands unsigned long, tim is u8. That causes quite some
warnings here.

...
>  static inline void bss_tim_clear(struct ieee80211_local *local,
>  				 struct ieee80211_if_ap *bss, int aid)
>  {
>  	spin_lock(&local->sta_lock);
> -	bss->tim[(aid)/8] &= !(1<<((aid) % 8));
> +	__bss_tim_clear(bss, aid);
>  	spin_unlock(&local->sta_lock);

Probably forgotten: we need _bh here as well.

Jan


Download attachment "signature.asc" of type "application/pgp-signature" (250 bytes)