netdev - Re: [PATCH] d80211: Fix inconsistent sta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1168102763.5207.61.camel@johannes.berg>
Date:	Sat, 06 Jan 2007 17:59:23 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Ivo van Doorn <ivdoorn@...il.com>
Cc:	Jiri Benc <jbenc@...e.cz>, Jan Kiszka <jan.kiszka@....de>,
	Christoph Hellwig <hch@...radead.org>, netdev@...r.kernel.org,
	rt2400-devel@...ts.sourceforge.net
Subject: Re: [PATCH] d80211: Fix inconsistent sta_lock usage

On Sat, 2007-01-06 at 17:52 +0100, Johannes Berg wrote:
> On Fri, 2007-01-05 at 21:08 +0100, Ivo van Doorn wrote:
> 
> > This patch uses the __set_bit and __clear_but as suggested by Christoph.
> > It also removes the local argument since it was unused.
> 
> NACK. This breaks spec compliance for drivers that use the TIM in their
> beacon frames.

Which, in fact, is the only point we keep track of the TIM, note that we
never actually test if bits there are set, the stack has better ways of
keeping track of the pending traffic.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)