netdev - Re: [PATCH 3/3] chelsio: more rx speedup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200701100934.46203.netdev@axxeo.de>
Date:	Wed, 10 Jan 2007 09:34:45 +0100
From:	Ingo Oeser <netdev@...eo.de>
To:	Divy Le Ray <divy@...lsio.com>
Cc:	Stephen Hemminger <shemminger@...l.org>,
	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] chelsio: more rx speedup

Divy Le Ray schrieb:
> Stephen Hemminger wrote:
> > On Tue, 9 Jan 2007 09:42:03 +0100
> > Ingo Oeser <netdev@...eo.de> wrote:
> >> Stephen Hemminger schrieb:
> >>> -	if (fl->credits < drop_thres) {
> >>> +use_orig_buf:
> >>> +	if (fl->credits < 2) {
> >>>       
> >> Why 2? What does this magic number mean?
> > No idea, it was there in the original. (as a parameter).
> The T2 HW behaves nicely when it is guaranteed to have 2 available 
> entries in the rx free list.

Can we have a #define for this?

That would help people understand this issue more.
And don't be shy about errata, all hardware and software out there has 
them like the humans that made them :-)

Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html