netdev - [IPROUTE 00/05]: Time cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070110100143.29356.98344.sendpatchset@localhost.localdomain>
Date:	Wed, 10 Jan 2007 11:01:43 +0100 (MET)
From:	Patrick McHardy <kaber@...sh.net>
To:	shemminger@...l.org
Cc:	netdev@...r.kernel.org, Patrick McHardy <kaber@...sh.net>
Subject: [IPROUTE 00/05]: Time cleanups

These patches clean up the tc time handling a bit, with the goal of making
it easier to audit for integer overflows when increasing the internal clock
resolution, which is necessary for all token bucket based schedulers to take
advantage of a higher kernel clock resolution (ktime) because the kernel only
does lookups and additions/subtractions, which can never result in values that
have a higher precision that those passed from userspace.

The way I imagine it we have to keep (at least on of) the old clock sources
around for userspace compatibility since they can't deal with the higher
precision values. iproute is changed to use nsec internally and reads the
kernel clock resulution from /proc/net/psched (third value, currently assumed
to always be 10^6) to convert it's internal resolution to that of the kernel.
With ktime as clocksource the kernel will report a resulution of 10^9. The
downside is that distributors can't enable ktime unless they want to break
compatibility with old iproute versions, but I can't see a way around this.

 tc/m_estimator.c  |    4 ++--
 tc/m_police.c     |    2 +-
 tc/q_cbq.c        |   15 ++++++++-------
 tc/q_hfsc.c       |   18 +++++++++---------
 tc/q_htb.c        |    4 ++--
 tc/q_netem.c      |   12 +++---------
 tc/q_tbf.c        |   20 ++++++++++----------
 tc/tc_cbq.c       |    8 ++++----
 tc/tc_core.c      |   35 +++++++++++++++++++++++++----------
 tc/tc_core.h      |   11 ++++++++---
 tc/tc_estimator.c |    2 +-
 tc/tc_red.c       |    2 +-
 tc/tc_util.c      |   33 +++++++++++++++++++--------------
 tc/tc_util.h      |    7 ++++---
 14 files changed, 97 insertions(+), 76 deletions(-)

Patrick McHardy:
      [IPROUTE]: Use tc_calc_xmittime where appropriate
      [IPROUTE]: Introduce tc_calc_xmitsize and use where appropriate
      [IPROUTE]: Introduce TIME_UNITS_PER_SEC to represent internal clock resolution
      [IPROUTE]: Replace "usec" by "time" in function names
      [IPROUTE]: Add sprint_ticks() function and use in CBQ
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html