netdev - Re: [IPSEC] flow: Cache negative results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070110232758.GB13180@gondor.apana.org.au>
Date:	Thu, 11 Jan 2007 10:27:58 +1100
From:	Herbert Xu <herbert.xu@...hat.com>
To:	Paul Moore <paul.moore@...com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	James Morris <jmorris@...hat.com>, netdev@...r.kernel.org
Subject: Re: [IPSEC] flow: Cache negative results

Hi Paul:

On Wed, Jan 10, 2007 at 11:11:43AM -0500, Paul Moore wrote:
> 
> I'm far from a flow cache expert (David, James, and Venkat will probably be 
> able to give you much better feedback) I did notice a few things which may or 
> may not be issues ... comments below.  FWIW, I believe Venkat is right in 
> that it shouldn't have any effect on the LSM code.
> 
> However, there is one other thing that came up when I was looking at your 
> patch, unrelated to your changes, that I wanted to ask about: in 
> net/core/flow.c:flow_entry_kill() ...
> 
> > static void flow_entry_kill(int cpu, struct flow_cache_entry *fle)
> > {
> >        if (fle->object)
> 
> Should this be "if (fle->object_ref)"?
> 
> >                atomic_dec(fle->object_ref);
> >        kmem_cache_free(flow_cachep, fle);
> >        flow_count(cpu)--; 
> > }

Yep this is a real bug.  Thanks for spotting it!

Although with Venkat's suggestion this change is no longer needed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html