netdev - Re: [PATCH 2/5] fixing errors handling during pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070112235054.GA5074@colo.lackof.org>
Date:	Fri, 12 Jan 2007 16:50:54 -0700
From:	Grant Grundler <grundler@...isc-linux.org>
To:	Dmitriy Monakhov <dmonakhov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	devel@...nvz.org, linux-pci@...ey.karlin.mff.cuni.cz,
	netdev@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 2/5] fixing errors handling during pci_driver resume stage [ata]

On Tue, Jan 09, 2007 at 12:01:28PM +0300, Dmitriy Monakhov wrote:
> ata pci drivers have to return correct error code during resume stage in
> case of errors.
...
> @@ -6246,8 +6253,10 @@ int ata_pci_device_suspend(struct pci_de
>  int ata_pci_device_resume(struct pci_dev *pdev)
>  {
>  	struct ata_host *host = dev_get_drvdata(&pdev->dev);
> +	int err;
>  
> -	ata_pci_device_do_resume(pdev);
> +	if ((err = ata_pci_device_do_resume(pdev)))
> +		return err;

nit: in every other case I looked at you did:
   err = foo()
   if (err) ...

Can you make that consistent here too?

thanks,
grant
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html