netdev - Re: [PATCH]: 8139cp: Don't blindly enable interrupts in cp_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070115233413.GA11037@gondor.apana.org.au>
Date:	Tue, 16 Jan 2007 10:34:13 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Chris Lalancette <clalance@...hat.com>, jgarzik@...ox.com,
	netdev@...r.kernel.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH]: 8139cp: Don't blindly enable interrupts in cp_start_xmit

On Mon, Jan 15, 2007 at 08:56:35PM +0100, Francois Romieu wrote:
> 
> As I understand http://lkml.org/lkml/2006/12/12/239, something like the
> patch below should had been sent instead. Herbert, ack/nak ?

Sorry, what I said in that thread is in error.  Netpoll may
unfortunately call the transmit routine with IRQs off.  So
the drivers can't currently use spin_lock_irq and must save
the current flags instead.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html