netdev - [PATCH 53/59] sysctl: Remove support for CTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <11689656972739-git-send-email-ebiederm@xmission.com>
Date:	Tue, 16 Jan 2007 09:39:58 -0700
From:	"Eric W. Biederman" <ebiederm@...ssion.com>
To:	"<Andrew Morton" <akpm@...l.org>
Cc:	<linux-kernel@...r.kernel.org>, <containers@...ts.osdl.org>,
	<netdev@...r.kernel.org>, xfs-masters@....sgi.com, xfs@....sgi.com,
	linux-scsi@...r.kernel.org, James.Bottomley@...elEye.com,
	minyard@....org, openipmi-developer@...ts.sourceforge.net,
	<tony.luck@...el.com>, linux-mips@...ux-mips.org,
	ralf@...ux-mips.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, linux390@...ibm.com,
	linux-390@...marist.edu, paulus@...ba.org, linuxppc-dev@...abs.org,
	lethal@...ux-sh.org, linuxsh-shmedia-dev@...ts.sourceforge.net,
	<ak@...e.de>, vojtech@...e.cz, clemens@...isch.de,
	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-parport@...ts.infradead.org, andrea@...e.de,
	tim@...erelk.net, philb@....org, aharkes@...cmu.edu,
	coda@...cmu.edu, codalist@...EMANN.coda.cs.cmu.edu,
	aia21@...tab.net, linux-ntfs-dev@...ts.sourceforge.net,
	mark.fasheh@...cle.com, kurt.hackel@...cle.com,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: [PATCH 53/59] sysctl: Remove support for CTL_ANY

From: Eric W. Biederman <ebiederm@...ssion.com> - unquoted

There are currently no users in the kernel for CTL_ANY and it
only has effect on the binary interface which is practically
unused.

So this complicates sysctl lookups for no good reason so just remove it.

Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
---
 include/linux/sysctl.h |    1 -
 kernel/sysctl.c        |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
index 63e1bac..c99e4bb 100644
--- a/include/linux/sysctl.h
+++ b/include/linux/sysctl.h
@@ -53,7 +53,6 @@ struct __sysctl_args {
 
 /* For internal pattern-matching use only: */
 #ifdef __KERNEL__
-#define CTL_ANY		-1	/* Matches any name */
 #define CTL_NONE	0
 #define CTL_UNNUMBERED	CTL_NONE	/* sysctl without a binary number */
 #endif
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 8da6647..e655b11 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1166,7 +1166,7 @@ repeat:
 	for ( ; table->ctl_name || table->procname; table++) {
 		if (!table->ctl_name)
 			continue;
-		if (n == table->ctl_name || table->ctl_name == CTL_ANY) {
+		if (n == table->ctl_name) {
 			int error;
 			if (table->child) {
 				if (ctl_perm(table, 001))
-- 
1.4.4.1.g278f

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html