netdev - Re: [PATCH -mm 3/10][RFC] aio: use iov_length instead of ki

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jan 2007 00:36:07 +0100
From:	Ingo Oeser <ioe-lkml@...eria.de>
To:	"Nate Diller" <nate.diller@...il.com>
Cc:	"Christoph Hellwig" <hch@...radead.org>,
	"Nate Diller" <nate@...mi.com>, "Andrew Morton" <akpm@...l.org>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Trond Myklebust" <trond.myklebust@....uio.no>,
	"Benjamin LaHaise" <bcrl@...ck.org>,
	"Alexander Viro" <viro@...iv.linux.org.uk>,
	"Suparna Bhattacharya" <suparna@...ibm.com>,
	"Kenneth W Chen" <kenneth.w.chen@...el.com>,
	"David Brownell" <dbrownell@...rs.sourceforge.net>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	netdev@...r.kernel.org, ocfs2-devel@....oracle.com,
	linux-aio@...ck.org, xfs-masters@....sgi.com
Subject: Re: [PATCH -mm 3/10][RFC] aio: use iov_length instead of ki_left

On Tuesday, 16. January 2007 06:37, Nate Diller wrote:
> On 1/15/07, Christoph Hellwig <hch@...radead.org> wrote:
> > On Mon, Jan 15, 2007 at 05:54:50PM -0800, Nate Diller wrote:
> > > Convert code using iocb->ki_left to use the more generic iov_length() call.
> >
> > No way.  We need to reduce the numer of iovec traversals, not adding
> > more of them.
> 
> ok, I can work on a version of this that uses struct iodesc.  Maybe
> something like this?
> 
> struct iodesc {
>         struct iovec *iov;
>         unsigned long nr_segs;
>         size_t nbytes;
> };
> 
> I suppose it's worth doing the iodesc thing along with this patchset
> anyway, since it'll avoid an extra round of interface churn.

What about this instead

struct iodesc {
	struct iovec *iov;
	unsigned long nr_segs;
	unsigned long seg_limit;
	size_t nr_bytes;
};

That will enable resizeable iodescs with partial completion state and
will enable successive filling of an iodesc with iovs.

This will be needed anyway. I built an complete short userspace 
module for that already. I can post and GPLv2 it somewhere, if people
are interested.

Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html