netdev - Re: TKIP encryption should allocate enough tailroom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070117033931.GX35756@gaz.sfgoth.com>
Date:	Tue, 16 Jan 2007 19:39:31 -0800
From:	Mitchell Blank Jr <mitch@...oth.com>
To:	Brandon Craig Rhodes <brandon@...desmill.org>
Cc:	netdev@...r.kernel.org
Subject: Re: TKIP encryption should allocate enough tailroom

Brandon Craig Rhodes wrote:
> +	if (skb_tailroom(skb) < 4) {
> +		int err;
> +		err = skb_padto(skb, skb->len + 4);
> +		if (unlikely(err || skb_tailroom(skb) < 4)) {
> +			printk(KERN_DEBUG "Failed to increase tailroom"
> +			       " for TKIP encrypt");
> +			return err || -1;

The "||" operator in C doesn't act the same way it does in perl and ruby.
You're always returning 1 here.

+			return err || -1;

...and here as well.

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html