netdev - Re: TKIP encryption should allocate enough tailroom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1H74Nq-0006N5-00@gondolin.me.apana.org.au>
Date:	Wed, 17 Jan 2007 17:34:54 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	brandon@...desmill.org (Brandon Craig Rhodes)
Cc:	mitch@...oth.com, netdev@...r.kernel.org
Subject: Re: TKIP encryption should allocate enough tailroom

Brandon Craig Rhodes <brandon@...desmill.org> wrote:
> 
> Egads!  You are correct.
> 
> My intention was to preserve the value of "err" if an unsuccessful
> value was returned by skb_padto(), and otherwise to return "-1" which
> seemed the popular value used for errors elsewhere in the code.
> 
> - Would the expression "err ? err : -1" have served me better?
> - Do error codes mean anything here, or should I simply say "return -1"?

err ?: -1

should work.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html