netdev - Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1169046072.2750.10.camel@localhost.localdomain>
Date:	Wed, 17 Jan 2007 10:01:12 -0500
From:	Dan Williams <dcbw@...hat.com>
To:	Jiri Benc <jbenc@...e.cz>
Cc:	Marcelo Tosatti <marcelo@...ck.org>,
	netdev <netdev@...r.kernel.org>, Jeff Garzik <jgarzik@...ox.com>,
	"John W. Linville" <linville@...hat.com>,
	"Luis R. Rodriguez" <mcgrof@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

On Wed, 2007-01-17 at 14:11 +0100, Jiri Benc wrote:
> On Tue, 16 Jan 2007 16:55:24 -0200, Marcelo Tosatti wrote:
> > Diff can be found at 
> > http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch
> > 
> > _Please_ review, this driver is targeted for mainline inclusion.
> 
> As long as there is yet another 802.11 stack inside, your chances to
> get this included are small.

There certainly isn't; with all the whining I've been doing over the
past two years about unified interfaces, we're not going to let a driver
through with Yet Another 802.11 Stack.  Sheesh, at least look at the
thing first.

The part is a mostly fullmac part that until now has been targetted at
the embedded market (PSP, N80 phone, etc).  That means that the driver
shouldn't be too large (airo is about 8000 kLOC without airo_cs) but for
some reason it still is; we're working on that.

But could we please be constructive here, and actually take a look at
the driver and point out problems?

Cheers,
Dan

[1] I've done a fair amount of work on this driver along with Marcelo

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html