netdev - Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1169003694.4778.15.camel@localhost.localdomain>
Date:	Wed, 17 Jan 2007 14:14:54 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	"<Andrew Morton" <akpm@...l.org>, linux-mips@...ux-mips.org,
	linux-parport@...ts.infradead.org, heiko.carstens@...ibm.com,
	ak@...e.de, linuxppc-dev@...abs.org, paulus@...ba.org,
	aharkes@...cmu.edu, schwidefsky@...ibm.com, tim@...erelk.net,
	rtc-linux@...glegroups.com, linux-scsi@...r.kernel.org,
	kurt.hackel@...cle.com, coda@...cmu.edu, vojtech@...e.cz,
	linuxsh-shmedia-dev@...ts.sourceforge.net,
	James.Bottomley@...elEye.com, clemens@...isch.de, xfs@....sgi.com,
	xfs-masters@....sgi.com, andrea@...e.de,
	openipmi-developer@...ts.sourceforge.net, linux-390@...marist.edu,
	codalist@...EMANN.coda.cs.cmu.edu, a.zummo@...ertech.it,
	tony.luck@...el.com, linux-ntfs-dev@...ts.sourceforge.net,
	netdev@...r.kernel.org, aia21@...tab.net,
	linux-kernel@...r.kernel.org, ralf@...ux-mips.org,
	lethal@...ux-sh.org, containers@...ts.osdl.org,
	linux390@...ibm.com, philb@....org
Subject: Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head
	flag

On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@...ssion.com> - unquoted
> 
> With unique sysctl binary numbers setting insert_at_head is pointless.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>

Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>

> ---
>  drivers/char/ipmi/ipmi_poweroff.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
> index 9d23136..b3ae65e 100644
> --- a/drivers/char/ipmi/ipmi_poweroff.c
> +++ b/drivers/char/ipmi/ipmi_poweroff.c
> @@ -686,7 +686,7 @@ static int ipmi_poweroff_init (void)
>  		printk(KERN_INFO PFX "Power cycle is enabled.\n");
>  
>  #ifdef CONFIG_PROC_FS
> -	ipmi_table_header = register_sysctl_table(ipmi_root_table, 1);
> +	ipmi_table_header = register_sysctl_table(ipmi_root_table, 0);
>  	if (!ipmi_table_header) {
>  		printk(KERN_ERR PFX "Unable to register powercycle sysctl\n");
>  		rv = -ENOMEM;

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html