lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Jan 2007 14:53:05 -0800 From: Jay Vosburgh <fubar@...ibm.com> To: Patrick McHardy <kaber@...sh.net> cc: mitch.a.williams@...el.com, linville@...driver.com, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: bonding: sysfs patch broke module renaming Patrick McHardy <kaber@...sh.net> wrote: >The sysfs patch broke using multiple instances of the bonding module >through module renaming (modprobe -o). In recent kernels it fails >with -EEXIST when trying to add the bonding_masters file for the >second time, in older kernels (where sysfs_add_file didn't check >for duplicates) it will crash when unloading the modules. Ok, I see what the problem is; it's got to do with out device creation was changed at some point for the sysfs stuff that broke the multiple load logic. I don't think it has to do with the sysfs_add_file duplicate check business; I can see the error in how bond_create() is called in the new (post-sysfs) stuff, although I haven't tracked it down to a particular changeset. There'a also a separate error handling bug I see in bond_create() that I don't even get to because it bails out first. Anyway, let me see what I can work out to fix this up. -J --- -Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists