lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 21 Jan 2007 13:45:27 -0800 From: Auke Kok <auke-jan.h.kok@...el.com> To: Frederik Deweerdt <deweerdt@...e.fr> CC: Andrei Popa <andrei.popa@...eo.ro>, linux-kernel@...r.kernel.org, nigel@...pend2.net, NetDev <netdev@...r.kernel.org> Subject: Re: [BUG] e100: eth0 appers many times in /proc/interrupts after resume Frederik Deweerdt wrote: > On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote: >> It's the 10th resume and in /proc/interrupts eth0 appers 10 times. > > The e100_resume() function should be calling netif_device_detach and > free_irq. Could you try the following (compile tested) patch? I just fixed suspend/shutdown for e100 in 2.6.19, not sure why the problem still shows up. Since it's a driver/net issue, you should CC netdev on it tho, otherwise it might go unnoticed. I'll open up the can-o-worms on this issue and see what's up with it. I'm not so sure that this patch is OK, and I wonder why it stopped working, because I spent quite some time fixing it only a few months ago. Did swsup change again? sigh... Auke > > Signed-off-by: Frederik Deweerdt <frederik.deweerdt@...il.com> > > diff --git a/drivers/net/e100.c b/drivers/net/e100.c > index 2fe0445..0c376e4 100644 > --- a/drivers/net/e100.c > +++ b/drivers/net/e100.c > @@ -2671,6 +2671,7 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state) > del_timer_sync(&nic->watchdog); > netif_carrier_off(nic->netdev); > > + netif_device_detach(netdev); > pci_save_state(pdev); > > if ((nic->flags & wol_magic) | e100_asf(nic)) { > @@ -2682,6 +2683,7 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state) > } > > pci_disable_device(pdev); > + free_irq(pdev->irq, netdev); > pci_set_power_state(pdev, PCI_D3hot); > > return 0; > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists