netdev - [RFC] airo.c: Description and function is not the same

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <45B35616.6040103@student.ltu.se>
Date:	Sun, 21 Jan 2007 13:01:26 +0100
From:	Richard Knutsson <ricknu-0@...dent.ltu.se>
To:	linville@...driver.com
CC:	netdev@...r.kernel.org
Subject: [RFC] airo.c: Description and function is not the same

Hello

In the tour of converting local definitions of boolean-type/values, I 
ran into airo.c's description of ex decapsulate():

 *      Returns: BOOLEAN - TRUE if packet should be dropped otherwise FALSE

but returns SUCCESS (defined as 0) and ERROR (defined as -1).

Also, shouldn't those functions be converted to return 'bool' when the 
description say so (happy to do it).

Richard Knutsson

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html