netdev - Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200701231002.49615.ak@suse.de>
Date:	Tue, 23 Jan 2007 10:02:49 +1100
From:	Andi Kleen <ak@...e.de>
To:	Neil Horman <nhorman@...driver.com>
Cc:	akpm@...l.org, netdev@...r.kernel.org
Subject: Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

On Tuesday 23 January 2007 00:00, Neil Horman wrote:
> As it is currently written, sys_select checks its return code to convert
> ERESTARTNOHAND to EINTR.  However, the check is within an if (tvp) clause,
> and so if select is called from userspace with a NULL timeval, then it is
> possible for the ERESTARTNOHAND errno to leak into userspace, which is
> incorrect.  This patch moves that check outside of the conditional, and
> prevents the errno leak.


Patch looks good to me.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html