netdev - Re: [PATCH 2/2] NetXen: Use pci_register_driver() instead of pci_module_init() in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45B5A570.5080408@garzik.org>
Date:	Tue, 23 Jan 2007 01:04:32 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	"Amit S. Kale" <amitkale@...xen.com>
CC:	netdev@...r.kernel.org, brazilnut@...ibm.com, linuxram@...ibm.com,
	netxenproj@...syssoft.com, ricknu-0@...dent.ltu.se, rob@...xen.com,
	sanjeev@...xen.com, wendyx@...ibm.com
Subject: Re: [PATCH 2/2] NetXen: Use pci_register_driver() instead of pci_module_init()
 in init_module

Amit S. Kale wrote:
> I am extremely sorry for sending this patch with wrong subject line before this.
> Now i am resending the patch with correct line.
> 
> Thanks,
> --Amit

Please include comments such as the above quoted /below/ the "---" 
terminator.

The git merge scripts copy everything preceding "---" directly into the 
kernel changelog.  Everything following "---", except the patch itself, 
is ignored by the automated tools.

	Jeff




> This will use pci_register_driver() instead of pci_module_init().
> 
> Signed-off-by: Amit S. Kale <amitkale@...xen.com>
> Signed-off-by: Richard Knutsson <ricknu-0@...dent.ltu.se>
> 
> ---
>  netxen_nic.h      |    2 +-
>  netxen_nic_main.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net/netxen/netxen_nic.h
> index 663fa2f..59324b1 100644
> --- a/drivers/net/netxen/netxen_nic.h
> +++ b/drivers/net/netxen/netxen_nic.h
> @@ -63,7 +63,7 @@ #include <asm/pgtable.h>
>  
>  #include "netxen_nic_hw.h"
>  
> -#define NETXEN_NIC_BUILD_NO     "1"
> +#define NETXEN_NIC_BUILD_NO     "2"

Please remove NETXEN_NIC_BUILD_NO, it is incompatible with Linux kernel 
development.  People who modify the kernel API, and then update drivers 
for that new API, will likely not bother with updating this variable, 
making it largely useless in practice.

	Jeff




-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html